hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17654) RSGroup code refactoring
Date Fri, 17 Feb 2017 01:36:41 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871017#comment-15871017
] 

stack commented on HBASE-17654:
-------------------------------

Tests failed.

I think Closeable is already removed?

There is already a Utility class for rsgroup called Utility so RSGroupUtil clashes. Leave
as it was?

How does RSGroupStartupWorker get an instance of masterServices now it does not take it in
constructor.

Any reason to change the ServerEventsListenerThread so it listened on events instead? (I'd
rather get rid of that thread if we could).

There is a bunch of nice cleanup in here.

RB is down. Will give you better review when it comes back.






> RSGroup code refactoring
> ------------------------
>
>                 Key: HBASE-17654
>                 URL: https://issues.apache.org/jira/browse/HBASE-17654
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Appy
>            Assignee: Appy
>         Attachments: HBASE-17654.master.001.patch, HBASE-17654.master.002.patch, HBASE-17654.master.003.patch
>
>
> TBD



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message