hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yu Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17638) Remove duplicated initialization of CacheConfig in HRegionServer
Date Mon, 13 Feb 2017 15:17:41 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15863811#comment-15863811
] 

Yu Li commented on HBASE-17638:
-------------------------------

UT looks good and just a minor clean up with no harm. Holding the commit until get another
+1.

> Remove duplicated initialization of CacheConfig in HRegionServer
> ----------------------------------------------------------------
>
>                 Key: HBASE-17638
>                 URL: https://issues.apache.org/jira/browse/HBASE-17638
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Yu Li
>            Assignee: Yu Li
>            Priority: Minor
>         Attachments: HBASE-17638.patch
>
>
> Before HBASE-11339, {{cacheConfig}} is only initialized once in {{HRegionServer#handleReportForDutyResponse}},
but twice afterwards (an additional one in constructor). Here we propose to keep the initialization
in constructor and remove the duplicated one in {{handleReportForDutyResponse}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message