hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17624) Address late review of HBASE-6721, rsgroups feature
Date Sat, 11 Feb 2017 07:43:42 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862291#comment-15862291
] 

Hadoop QA commented on HBASE-17624:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s {color} | {color:blue}
Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} rubocop {color} | {color:blue} 0m 0s {color} | {color:blue}
rubocop was not available. {color} |
| {color:blue}0{color} | {color:blue} ruby-lint {color} | {color:blue} 0m 0s {color} | {color:blue}
Ruby-lint was not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} |
{color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green}
The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color}
| {color:green} The patch appears to include 9 new or modified test files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 26s {color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 5s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 49s {color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 56s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 14s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 30s {color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 27s {color} |
{color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 11s {color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 58s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 48s {color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 48s {color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 56s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 15s {color}
| {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s {color} | {color:red}
The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s {color} | {color:green}
The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 27m 9s {color}
| {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5
2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 37s {color} | {color:red}
hbase-rsgroup generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 26s {color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 49s {color} | {color:green}
hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 56s {color} | {color:red}
hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 15m 49s {color} | {color:red}
hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 15m 20s {color} | {color:red}
hbase-rsgroup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 4m 34s {color} | {color:red}
hbase-shell in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 17s {color} | {color:green}
hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 50s {color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 94m 11s {color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-rsgroup |
|  |  Nullcheck of sourceGroupName at line 156 of value previously dereferenced in org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveServers(Set,
String)  At RSGroupAdminServer.java:156 of value previously dereferenced in org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveServers(Set,
String)  At RSGroupAdminServer.java:[line 156] |
| Failed junit tests | hadoop.hbase.client.TestSimpleRequestController |
|   | hadoop.hbase.TestServerName |
|   | hadoop.hbase.rsgroup.TestRSGroupsOfflineMode |
|   | hadoop.hbase.client.rsgroup.TestShellRSGroups |
| Timed out junit tests | org.apache.hadoop.hbase.rsgroup.TestRSGroups |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12852184/HBASE-17624.master.001.patch
|
| JIRA Issue | HBASE-17624 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  hbaseanti  checkstyle
 compile  xml  rubocop  ruby_lint  |
| uname | Linux c1173f69f444 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / a05abd8 |
| Default Java | 1.8.0_121 |
| findbugs | v3.0.0 |
| whitespace | https://builds.apache.org/job/PreCommit-HBASE-Build/5674/artifact/patchprocess/whitespace-eol.txt
|
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/5674/artifact/patchprocess/new-findbugs-hbase-rsgroup.html
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/5674/artifact/patchprocess/patch-unit-hbase-client.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/5674/artifact/patchprocess/patch-unit-hbase-server.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/5674/artifact/patchprocess/patch-unit-hbase-rsgroup.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/5674/artifact/patchprocess/patch-unit-hbase-shell.txt
|
| unit test logs |  https://builds.apache.org/job/PreCommit-HBASE-Build/5674/artifact/patchprocess/patch-unit-hbase-client.txt
https://builds.apache.org/job/PreCommit-HBASE-Build/5674/artifact/patchprocess/patch-unit-hbase-server.txt
https://builds.apache.org/job/PreCommit-HBASE-Build/5674/artifact/patchprocess/patch-unit-hbase-rsgroup.txt
https://builds.apache.org/job/PreCommit-HBASE-Build/5674/artifact/patchprocess/patch-unit-hbase-shell.txt
|
|  Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/5674/testReport/ |
| modules | C: hbase-common hbase-client hbase-server hbase-rsgroup hbase-shell hbase-it U:
. |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/5674/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> Address late review of HBASE-6721, rsgroups feature
> ---------------------------------------------------
>
>                 Key: HBASE-17624
>                 URL: https://issues.apache.org/jira/browse/HBASE-17624
>             Project: HBase
>          Issue Type: Bug
>          Components: rsgroup
>            Reporter: stack
>            Assignee: stack
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17624.master.001.patch, HBASE-17624.master.002.patch
>
>
> An internal review by [~busbey] and [~appy] turned up a bunch of good findings going
over HBASE-6721. They found some really good stuff a guava type is part of our public API
and concurrency in a few core classes is inconsistent.
> Patch coming.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message