hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17613) avoid copy of family when initializing the FSWALEntry
Date Thu, 09 Feb 2017 19:36:41 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15860050#comment-15860050
] 

Hudson commented on HBASE-17613:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #2474 (See [https://builds.apache.org/job/HBase-Trunk_matrix/2474/])
HBASE-17613 avoid copy of family when initializing the FSWALEntry (tedyu: rev 489c8872c14fc8c4c9cd5d36b1953bf5afcf08ec)
* (add) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestFSWALEntry.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSWALEntry.java


> avoid copy of family when initializing the FSWALEntry
> -----------------------------------------------------
>
>                 Key: HBASE-17613
>                 URL: https://issues.apache.org/jira/browse/HBASE-17613
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: ChiaPing Tsai
>            Assignee: ChiaPing Tsai
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17613.v0.patch, HBASE-17613.v1.patch, HBASE-17613.v2.patch,
HBASE-17613.v2.patch
>
>
> We should compare the families before cloning it.
> {noformat}
> Set<byte[]> familySet = Sets.newTreeSet(Bytes.BYTES_COMPARATOR);
> for (Cell cell : cells) {
>   if (!CellUtil.matchingFamily(cell, WALEdit.METAFAMILY)) {
>   // TODO: Avoid this clone?
>     familySet.add(CellUtil.cloneFamily(cell));
>   }
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message