hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duo Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17599) Also set the partial flag of Result to true if we reach the batch limit
Date Mon, 06 Feb 2017 09:10:41 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15853722#comment-15853722

Duo Zhang commented on HBASE-17599:

Does this issue want to set flag in proto of response only, or expose to users' Result.isPartial()?
At least in proto, so we can simplity the logic of client code. We can reset the partial flag
before returning the Result to user if we really want to keep the old behavior but I do not
think this is necessary?

> Also set the partial flag of Result to true if we reach the batch limit
> -----------------------------------------------------------------------
>                 Key: HBASE-17599
>                 URL: https://issues.apache.org/jira/browse/HBASE-17599
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client, scan
>    Affects Versions: 2.0.0, 1.4.0
>            Reporter: Duo Zhang
>             Fix For: 2.0.0, 1.4.0
>         Attachments: HBASE-17599.patch
> For now if we set scan.allowPartial(true), the partial result returned will have the
partial flag set to true. But for scan.setBatch(xx), the partial result returned will not
be marked as partial.
> This is an Incompatible change, indeed. But I do not think it will introduce any issues
as we just provide more informations to client. The old partial flag for batched scan is always
false so I do not think anyone can make use of it.
> This is very important for the limited scan to support partial results from server. If
we get a Result which partial flag is false then we know we get the whole row. Otherwise we
need to fetch one more row to see if the row key is changed which causes the logic to be more

This message was sent by Atlassian JIRA

View raw message