hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Helmling (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17582) Drop page cache hint is broken
Date Thu, 02 Feb 2017 21:31:51 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15850546#comment-15850546
] 

Gary Helmling commented on HBASE-17582:
---------------------------------------

On the write side, from what I can see, this was never fully hooked up.  The value set in
the Builder doesn't look like it was ever passed through to the Writer constructor.  So the
boolean needs to be passed through from the Writer Builder -> StoreFileWriter constructor
-> WriterFactory.  If it is piped through, it will be used in WriterFactory.create().

> Drop page cache hint is broken
> ------------------------------
>
>                 Key: HBASE-17582
>                 URL: https://issues.apache.org/jira/browse/HBASE-17582
>             Project: HBase
>          Issue Type: Bug
>          Components: Compaction, io
>    Affects Versions: 2.0.0
>            Reporter: Ashu Pachauri
>            Assignee: Appy
>            Priority: Critical
>         Attachments: HBASE-17582.master.001.patch
>
>
> We pass a boolean for pass page cache drop hint while creating store file scanners and
writers. 
> The hint is not passed on down the stack by StoreFileWriter and StoreFileScanner in the
master branch.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message