hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Helmling (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-17578) Thrift per-method metrics should still update in the case of exceptions
Date Mon, 06 Feb 2017 20:44:41 GMT

     [ https://issues.apache.org/jira/browse/HBASE-17578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Gary Helmling updated HBASE-17578:
       Resolution: Fixed
    Fix Version/s: 1.4.0
           Status: Resolved  (was: Patch Available)

Applied to branch-1.3+.

I took a brief look at branch-1.2, but there are quite a few differences in the metrics classes,
so I'm leaving it out there.  If there is interest in a more targeted fix for earlier branches,
we can create a separate issue for a backport.

> Thrift per-method metrics should still update in the case of exceptions
> -----------------------------------------------------------------------
>                 Key: HBASE-17578
>                 URL: https://issues.apache.org/jira/browse/HBASE-17578
>             Project: HBase
>          Issue Type: Bug
>          Components: Thrift
>            Reporter: Gary Helmling
>            Assignee: Gary Helmling
>             Fix For: 2.0.0, 1.4.0, 1.3.1
>         Attachments: HBASE-17578.001.patch, HBASE-17578.002.patch, HBASE-17578.002.patch
> Currently, the InvocationHandler used to update per-method metrics in the Thrift server
fails to update metrics if an exception occurs.  This causes us to miss outliers.  We should
include exceptional cases in per-method latencies, and also look at adding specific exception
rate metrics.

This message was sent by Atlassian JIRA

View raw message