hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17578) Thrift per-method metrics should still update in the case of exceptions
Date Tue, 07 Feb 2017 00:28:42 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15855041#comment-15855041
] 

Hudson commented on HBASE-17578:
--------------------------------

SUCCESS: Integrated in Jenkins build HBase-1.3-JDK7 #93 (See [https://builds.apache.org/job/HBase-1.3-JDK7/93/])
HBASE-17578 Thrift metrics should handle exceptions (garyh: rev d53fafdeedafcf8cc5ed636f61af65e6e09f635d)
* (edit) hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java
* (edit) hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
* (edit) hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/HbaseHandlerMetricsProxy.java
* (edit) hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
* (add) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/metrics/ExceptionTrackingSourceImpl.java
* (edit) hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java
* (edit) hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
* (add) hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/ErrorThrowingGetObserver.java
* (add) hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/metrics/ExceptionTrackingSource.java
* (edit) hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/thrift/MetricsThriftServerSource.java
* (edit) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSourceImpl.java
* (edit) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/thrift/MetricsThriftServerSourceImpl.java
* (edit) hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSource.java


> Thrift per-method metrics should still update in the case of exceptions
> -----------------------------------------------------------------------
>
>                 Key: HBASE-17578
>                 URL: https://issues.apache.org/jira/browse/HBASE-17578
>             Project: HBase
>          Issue Type: Bug
>          Components: Thrift
>            Reporter: Gary Helmling
>            Assignee: Gary Helmling
>             Fix For: 2.0.0, 1.4.0, 1.3.1
>
>         Attachments: HBASE-17578.001.patch, HBASE-17578.002.patch, HBASE-17578.002.patch
>
>
> Currently, the InvocationHandler used to update per-method metrics in the Thrift server
fails to update metrics if an exception occurs.  This causes us to miss outliers.  We should
include exceptional cases in per-method latencies, and also look at adding specific exception
rate metrics.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message