hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Helmling (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-17578) Thrift per-method metrics should still update in the case of exceptions
Date Wed, 01 Feb 2017 20:43:51 GMT

     [ https://issues.apache.org/jira/browse/HBASE-17578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Gary Helmling updated HBASE-17578:
----------------------------------
    Attachment: HBASE-17578.001.patch

In addition to fixing the metrics InvocationHandlers for thrift 1 & 2 to always increment
latencies, even in the case of exceptions, the attached patch also adds common exception handling
and reporting for the thrift server implementations.  The metrics reporting for common exception
types is now shared between regionservers, and thrift 1 & 2.

> Thrift per-method metrics should still update in the case of exceptions
> -----------------------------------------------------------------------
>
>                 Key: HBASE-17578
>                 URL: https://issues.apache.org/jira/browse/HBASE-17578
>             Project: HBase
>          Issue Type: Bug
>          Components: Thrift
>            Reporter: Gary Helmling
>            Assignee: Gary Helmling
>             Fix For: 1.3.1
>
>         Attachments: HBASE-17578.001.patch
>
>
> Currently, the InvocationHandler used to update per-method metrics in the Thrift server
fails to update metrics if an exception occurs.  This causes us to miss outliers.  We should
include exceptional cases in per-method latencies, and also look at adding specific exception
rate metrics.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message