hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17575) Towards Making BASIC the Default In-Memory Compaction Policy
Date Fri, 03 Feb 2017 06:37:51 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851140#comment-15851140

stack commented on HBASE-17575:

I was going to object that this is awkward [~eshcar]... passing a flag to a general test to
enable a sub-feature:     tag = new TestAcidGuarantees(CompactingMemStore.COMPACTING_MEMSTORE_TYPE_DEFAULT);
... but maybe we should be doing more of this instead; i.e. TestAcidGuarantees with all sorts
of feature parameters. TAG only tests the default as is. If it were parameterized to flip
on and off different feature combinations, it could turn up some interesting failure types.
 I suppose we can wonder about how to add different feature-type parameters for TAG at a latter
time when someone wants to do it and go w/ Accordion parameters only for now.

This change is interesting: 57	      scanners.add(segment.getScanner(Integer.MAX_VALUE));
 We are doing 'dirty reads'?

No mslab? Or is that later?
	    conf.setBoolean(MemStoreLAB.USEMSLAB_KEY, false);

Patch is radical (smile) adding loads of testing of inmemory compaction in various scenarios.
+1. I'll commit if you good with it [~anoop.hbase] You have an idea of how much longer our
test suite is now running with these parameterizations [~eshcar]? Thanks.

> Towards Making BASIC the Default In-Memory Compaction Policy
> ------------------------------------------------------------
>                 Key: HBASE-17575
>                 URL: https://issues.apache.org/jira/browse/HBASE-17575
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Eshcar Hillel
>            Assignee: Eshcar Hillel
>             Fix For: 2.0.0
>         Attachments: HBASE-17575-V01.patch, HBASE-17575-V01.patch
> In preparation for switching the default in-memory compaction policy to BASIC, we would
like to make sure that once we do the switch all tests will run (and pass!) with the new default
> To this end, we remove the NONE configuration setting added to tests in HBASE-17294 and
> We verified these tests pass with all 3 memory compaction policies.
> For each test 
> (1) if all 3 policies pass the test -- we remove the configuration from the test.
> (2) if some fail we add tests of all 3 configurations, e.g., by parameterized tests.
When needed we update expected results.
> One test failure identified a small bug which is also fixed in the patch.

This message was sent by Atlassian JIRA

View raw message