hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17465) [C++] implement request retry mechanism over RPC
Date Sat, 11 Feb 2017 01:27:41 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862125#comment-15862125

Enis Soztutar commented on HBASE-17465:

bq. It is fine if you want to do this in a future patch.
Was looking at this again offline with [~xiaobingo]. We are using the base class only for
master callables. So, let's leave this as it is in this patch. 

Together with this: {{if/Client.proto}}, I think we need to change the one in {{./hbase-protocol/src/main/protobuf/Client.proto}}
(bin/copy-protobuf.sh copies this to under {{hbase-native-client/if/}} directory). 

- For the test, you do not need to re-use the XML creation from {{client-test.h}}. You can
undo that, and instead create a client like this: 
Configuration conf;
hbase::Client client(conf);

Otherwise, the logic for exception handling, retries, timeouts, etc is pretty solid and very
close to the existing impl. 

> [C++] implement request retry mechanism over RPC
> ------------------------------------------------
>                 Key: HBASE-17465
>                 URL: https://issues.apache.org/jira/browse/HBASE-17465
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Xiaobing Zhou
>            Assignee: Xiaobing Zhou
>         Attachments: HBASE-17465-HBASE-14850.000.patch, HBASE-17465-HBASE-14850.001.patch,
HBASE-17465-HBASE-14850.002.patch, HBASE-17465-HBASE-14850.003.patch, HBASE-17465-HBASE-14850.004.patch,
HBASE-17465-HBASE-14850.005.patch, HBASE-17465-HBASE-14850.006.patch, HBASE-17465-HBASE-14850.007.patch
> HBASE-17051 implemented RPC layer. Requests retries will make system reliable. This JIRA
proposes adding it, which corresponds to similar implementation in  SingleRequestCallerBuilder
(or BatchCallerBuilder, ScanSingleRegionCallerBuilder, SmallScanCallerBuilder, etc.) and AsyncSingleRequestRpcRetryingCaller.
As a bonus, retry should be more generic, decoupled with HRegionLocation.

This message was sent by Atlassian JIRA

View raw message