hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17465) [C++] implement request retry mechanism over RPC
Date Fri, 10 Feb 2017 23:16:41 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861989#comment-15861989

Enis Soztutar commented on HBASE-17465:

Thanks [~xiaobingo] for the patches. 
I was able to compile v7, which is good. I think it is getting into pretty good shape. 

- {{AsyncConnection}} is not used in this patch. We can leave it our for now (if you are not
gonna use it in tests). Also no need to differentiate AsyncConnection interface vs implementation
- async-rpc-retrying-caller and caller-factory code is in the {{.h}} files. Should those go
to {{.cc}}?
- You can just use the HBaseRpcController, no need to make custom RpcContollerFacotry yet.

- rename ElapsedMs() to ElapsedMillis() 
- In the Java land, AsyncSingleRequestRpcRetryingCaller extends AsyncRpcRetryingCaller which
handles most of the functionality. Do you want to do that in a later patch or here? I think
future work (like the batch caller, and scan callers, etc) will want to share the exception
handling and timeout, etc logic. It is fine if you want to do this in a future patch. 

> [C++] implement request retry mechanism over RPC
> ------------------------------------------------
>                 Key: HBASE-17465
>                 URL: https://issues.apache.org/jira/browse/HBASE-17465
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Xiaobing Zhou
>            Assignee: Xiaobing Zhou
>         Attachments: HBASE-17465-HBASE-14850.000.patch, HBASE-17465-HBASE-14850.001.patch,
HBASE-17465-HBASE-14850.002.patch, HBASE-17465-HBASE-14850.003.patch, HBASE-17465-HBASE-14850.004.patch,
HBASE-17465-HBASE-14850.005.patch, HBASE-17465-HBASE-14850.006.patch, HBASE-17465-HBASE-14850.007.patch
> HBASE-17051 implemented RPC layer. Requests retries will make system reliable. This JIRA
proposes adding it, which corresponds to similar implementation in  SingleRequestCallerBuilder
(or BatchCallerBuilder, ScanSingleRegionCallerBuilder, SmallScanCallerBuilder, etc.) and AsyncSingleRequestRpcRetryingCaller.
As a bonus, retry should be more generic, decoupled with HRegionLocation.

This message was sent by Atlassian JIRA

View raw message