hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17437) Support specifying a WAL directory outside of the root directory
Date Wed, 08 Feb 2017 01:53:42 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857224#comment-15857224
] 

Enis Soztutar commented on HBASE-17437:
---------------------------------------

I was checking the branch-1 patch. 
We are not doing this in the master patch: 
{code}
+    checkRootDir(this.rootdir, conf, this.fs, HConstants.HBASE_DIR, HBASE_DIR_PERMS);
+    // if the log directory is different from root, check if it exists
+    if (!this.walRootDir.equals(this.rootdir)) {
+      checkRootDir(this.walRootDir, conf, this.walFs, HFileSystem.HBASE_WAL_DIR, HBASE_WAL_DIR_PERMS);
+    }
{code}
we only check for the root dir. Is this needed in both? Seems likely. We can do an addendum
to master if needed. 

Do we need to check both the root dir, and the wal dir here (and in the checks below)? 
{code}
-    if (this.fsOk) {
+    if (this.walFsOk) {
{code}





> Support specifying a WAL directory outside of the root directory
> ----------------------------------------------------------------
>
>                 Key: HBASE-17437
>                 URL: https://issues.apache.org/jira/browse/HBASE-17437
>             Project: HBase
>          Issue Type: Improvement
>          Components: Filesystem Integration, wal
>    Affects Versions: 1.2.4
>            Reporter: Yishan Yang
>            Assignee: Zach York
>              Labels: patch
>             Fix For: 2.0.0, 1.4.0
>
>         Attachments: HBASE-17437.branch-1.001.patch, HBASE-17437.branch-1.002.patch,
HBASE-17437.branch-1.003.patch, HBASE-17437.branch-1.004.patch, hbase-17437-branch-1.2.patch,
HBASE-17437.master.001.patch, HBASE-17437.master.002.patch, HBASE-17437.master.003.patch,
HBASE-17437.master.004.patch, HBASE-17437.master.005.patch, HBASE-17437.master.006.patch,
HBASE-17437.master.007.patch, HBASE-17437.master.008.patch, HBASE-17437.master.009.patch,
HBASE-17437.master.010.patch, HBASE-17437.master.011.patch, HBASE-17437.master.012.patch,
hbase-17437-master.patch
>
>
> Currently, the WAL and the StoreFiles need to be on the same FileSystem. Some FileSystems
(such as Amazon S3) don’t support append or consistent writes. These two properties are
imperative for the WAL in order to avoid loss of writes. However, StoreFiles don’t necessarily
need the same consistency guarantees (since writes are cached locally and if writes fail,
they can always be replayed from the WAL).
>  
> This JIRA aims to allow users to configure a log directory (for WALs) that is outside
of the root directory or even in a different FileSystem. The default value will still put
the log directory under the root directory.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message