hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Appy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17312) [JDK8] Use default method for Observer Coprocessors
Date Thu, 16 Feb 2017 00:23:42 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868872#comment-15868872
] 

Appy commented on HBASE-17312:
------------------------------

I would suggest deleting the Base...Observer classes since
- it's 2.0, we can break compatability
- we won't have to maintaining these deprecated classes. Right now every time a master or
region hook is added, we have to duplicate it in two other places.
- it would be breeze for third parties to fix this breakage; just one line change. "extends
BaseFooObserver" -> "implements FooObserver".


> [JDK8] Use default method for Observer Coprocessors
> ---------------------------------------------------
>
>                 Key: HBASE-17312
>                 URL: https://issues.apache.org/jira/browse/HBASE-17312
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>    Affects Versions: 2.0.0
>            Reporter: Guanghao Zhang
>            Assignee: Guanghao Zhang
>         Attachments: HBASE-17312.master.001.patch, HBASE-17312.master.001.patch
>
>
> Use default method in MasterObserver, RegionObserver, RegionServerObserver and WALObserver.
And mark the BaseRegionObserver, BaseMasterAndRegionObserver, BaseRegionServerObserver and
BaseWALObserver. User can implement the interface directly and will not break compatibility
when add new default methods.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message