hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15597) Clean up configuration keys used in hbase-spark module
Date Mon, 13 Feb 2017 19:23:41 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864260#comment-15864260
] 

Hadoop QA commented on HBASE-15597:
-----------------------------------

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 9s {color} | {color:blue}
Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green}
The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color}
| {color:green} The patch appears to include 4 new or modified test files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 8s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 58s {color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} scaladoc {color} | {color:green} 0m 26s {color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 51s {color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} scalac {color} | {color:green} 0m 51s {color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 34m 4s {color}
| {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5
2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} scaladoc {color} | {color:green} 0m 34s {color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 53s {color} | {color:green}
hbase-spark in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 9s {color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 44m 25s {color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12852394/HBASE-15597-V2.patch
|
| JIRA Issue | HBASE-15597 |
| Optional Tests |  asflicense  scalac  scaladoc  unit  compile  |
| uname | Linux e17a09814c11 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 3fe5102 |
|  Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/5695/testReport/ |
| modules | C: hbase-spark U: hbase-spark |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/5695/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> Clean up configuration keys used in hbase-spark module
> ------------------------------------------------------
>
>                 Key: HBASE-15597
>                 URL: https://issues.apache.org/jira/browse/HBASE-15597
>             Project: HBase
>          Issue Type: Bug
>          Components: spark
>    Affects Versions: 2.0.0
>            Reporter: Sean Busbey
>            Assignee: Yi Liang
>            Priority: Critical
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15597-v1.patch, HBASE-15597-V2.patch
>
>
> This should be considered a blocker for backport to branch-1 since it will impact our
compatibility.
> The constants we expose in configuration should all start with "hbase". Since our configurations
keys for the spark integration all relate to that system, the prefix for all configuration
keys (excluding those cases where we need to do something special due to restrictions in how
properties are handled by e.g. spark) should be "hbase.spark".
> Before publishing a public api labeled version of our spark integration we should review
all of our configuration keys to make sure they either conform to the "hbase.spark" prefix
or they have a comment documenting why they need to be otherwise.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message