hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15328) Unvalidated Redirect in HMaster
Date Wed, 22 Feb 2017 02:03:44 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15877282#comment-15877282
] 

Hudson commented on HBASE-15328:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-1.1-JDK8 #1929 (See [https://builds.apache.org/job/HBase-1.1-JDK8/1929/])
HBASE-15328 sanity check the redirect used to send master info requests (busbey: rev daf2dc9a8a07caee646bf5f97c451e062075d4a7)
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestInfoServers.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java


> Unvalidated Redirect in HMaster
> -------------------------------
>
>                 Key: HBASE-15328
>                 URL: https://issues.apache.org/jira/browse/HBASE-15328
>             Project: HBase
>          Issue Type: Bug
>          Components: security
>            Reporter: stack
>            Assignee: Sean Busbey
>            Priority: Minor
>             Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.10
>
>         Attachments: HBASE-15328.0.patch, HBASE-15328.1.patch
>
>
> See OWASP page on why we should clean it up someday:
> https://www.owasp.org/index.php/Unvalidated_Redirects_and_Forwards_Cheat_Sheet
> Here is where we do the redirect:
> {code}
>     @Override
>     public void doGet(HttpServletRequest request,
>         HttpServletResponse response) throws ServletException, IOException {
>       String redirectUrl = request.getScheme() + "://"
>         + request.getServerName() + ":" + regionServerInfoPort
>         + request.getRequestURI();
>       response.sendRedirect(redirectUrl);
>     }
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message