hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "chunhui shen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15314) Allow more than one backing file in bucketcache
Date Sun, 26 Feb 2017 02:40:44 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15884497#comment-15884497

chunhui shen commented on HBASE-15314:

Shouldn't sizePerFile be adjusted since total space is lower than sizePerFile ?
When total space is lower than sizePerFile, the above would raise exception, right ?
Yes, if the space is less than sizePerFile,  FileIOEngine will throw exception when initializing,
 it's unnecessary to adjust the sizePerFile.

For getFileNum(long offset), RuntimeException may be thrown. Should it declare to throw IOE
It won't be thrown as expected, RuntimeException  seems ok.

+   * Get the absolute offset in given file with the relative global offset.
What does "relative global" mean ?
The FileIOEngine provide a logic contiguous storage  with several physical files,  the global
offset is oriented to the logic storage.

Thanks Ted, Other comments are applied in patch-v5.

Move to RB https://reviews.apache.org/r/57068/ for more review.

> Allow more than one backing file in bucketcache
> -----------------------------------------------
>                 Key: HBASE-15314
>                 URL: https://issues.apache.org/jira/browse/HBASE-15314
>             Project: HBase
>          Issue Type: Sub-task
>          Components: BucketCache
>            Reporter: stack
>            Assignee: Aaron Tokhy
>         Attachments: FileIOEngine.java, HBASE-15314.master.001.patch, HBASE-15314.master.001.patch,
HBASE-15314.patch, HBASE-15314-v2.patch, HBASE-15314-v3.patch, HBASE-15314-v4.patch, HBASE-15314-v5.patch
> Allow bucketcache use more than just one backing file: e.g. chassis has more than one
SSD in it.

This message was sent by Atlassian JIRA

View raw message