hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-9702) Change unittests that use "table" or "testtable" to use method names.
Date Mon, 13 Feb 2017 21:31:41 GMT

     [ https://issues.apache.org/jira/browse/HBASE-9702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

stack updated HBASE-9702:
       Resolution: Fixed
     Hadoop Flags: Reviewed
    Fix Version/s: 2.0.0
     Release Note: Changes all tests to use the TestName JUnit Rule everywhere rather than
hardcode table/region/store names.
           Status: Resolved  (was: Patch Available)

I pushed this after trying failed test locally (passes). This is nice cleanup. Thanks for
the patch [~Jan Hentschel].

> Change unittests that use "table" or "testtable" to use method names.
> ---------------------------------------------------------------------
>                 Key: HBASE-9702
>                 URL: https://issues.apache.org/jira/browse/HBASE-9702
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>            Reporter: Jonathan Hsieh
>            Assignee: Jan Hentschel
>             Fix For: 2.0.0
>         Attachments: HBASE-9702.master.001.patch, HBASE-9702.master.002.patch
> While working on HBASE-9686, many tests left files that indicated the method they had
come from but several drop data in "table" or "testtable" tables.  Naming them this way makes
it hard to track which tests these came from.  We should make all test use 
> @Rule TestName name = new TestName();
> ...
> TableName  t = TableName.valueOf(name.getMethodName());

This message was sent by Atlassian JIRA

View raw message