hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-3462) Fix table.jsp in regards to splitting a region/table with an optional splitkey
Date Wed, 01 Feb 2017 00:19:51 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847768#comment-15847768
] 

Hadoop QA commented on HBASE-3462:
----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 39s {color} | {color:blue}
Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green}
The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s {color} | {color:red}
The patch doesn't appear to include any new or modified tests. Please justify why no new tests
are needed for this patch. Also please list what manual steps were performed to verify this
patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 42s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 15s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s {color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 44s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 15s {color}
| {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s {color} | {color:red}
The patch 1 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 28m 44s {color}
| {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5
2.7.1 2.7.2 2.7.3 or 3.0.0-alpha1. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s {color} |
{color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 104m 51s {color} | {color:red}
hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s {color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 140m 38s {color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestZKAsyncRegistry |
| Timed out junit tests | org.apache.hadoop.hbase.regionserver.wal.TestLogRolling |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.6 Server=1.12.6 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12850315/HBASE-3462-BM-01.patch
|
| JIRA Issue | HBASE-3462 |
| Optional Tests |  asflicense  javac  javadoc  unit  |
| uname | Linux df2cb845dd0b 3.13.0-100-generic #147-Ubuntu SMP Tue Oct 18 16:48:51 UTC 2016
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 5ebaadf |
| Default Java | 1.8.0_121 |
| whitespace | https://builds.apache.org/job/PreCommit-HBASE-Build/5527/artifact/patchprocess/whitespace-tabs.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/5527/artifact/patchprocess/patch-unit-hbase-server.txt
|
| unit test logs |  https://builds.apache.org/job/PreCommit-HBASE-Build/5527/artifact/patchprocess/patch-unit-hbase-server.txt
|
|  Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/5527/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/5527/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> Fix table.jsp in regards to splitting a region/table with an optional splitkey
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-3462
>                 URL: https://issues.apache.org/jira/browse/HBASE-3462
>             Project: HBase
>          Issue Type: Improvement
>          Components: master
>    Affects Versions: 0.90.0
>            Reporter: Lars George
>            Assignee: Balazs Meszaros
>              Labels: beginner
>             Fix For: 2.0.0
>
>         Attachments: HBASE-3462-BM-01.patch, HBASE-3462-BM-01.patch
>
>
> After HBASE-3328 and HBASE-3437 went in there is also the table.jsp that needs updating
to support the same features. Also, at the same time update the wording, for example 
> {quote}
> This action will force a split of all eligible regions of the table, or, if a key is
supplied, only the region containing the given key. An eligible region is one that does not
contain any references to other regions. Split requests for noneligible regions will be ignored.
> {quote}
> I think it means it splits either all regions (that are splittable) or a specific one.
It says though "the region containing the given key", that seems wrong in any event. Currently
we do a split on the tablename when nothing was specified or else do an internal get(region),
which is an exact match on the rows in .META.. In other words you need to match the region
name exactly or else it fails. It reports it has accepted the request but logs internally
> {code}
> 2011-01-21 15:37:24,340 INFO org.apache.hadoop.hbase.client.HBaseAdmin: No server in
.META. for csfsef; pair=null
> {code}
> Error reporting could be better but because of the async nature this is more difficult,
yet it would be nice there is some concept of a Future to be able to poll the result if needed.
> Finally, when you go back to the previous page after submitting the split the entered
values show up in the "compact" input fields, at least on my Chrome. The inputs in both forms
are named the same so it seems to confuse it. This could be improved a lot by making the landing
page reload the main one automatically or refresh on reload instead of submitting the request
again.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message