Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 89C77200C08 for ; Thu, 26 Jan 2017 18:28:34 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 86A91160B4C; Thu, 26 Jan 2017 17:28:34 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CF4F0160B31 for ; Thu, 26 Jan 2017 18:28:33 +0100 (CET) Received: (qmail 88626 invoked by uid 500); 26 Jan 2017 17:28:33 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 88614 invoked by uid 99); 26 Jan 2017 17:28:33 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Jan 2017 17:28:33 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 226B01A036E for ; Thu, 26 Jan 2017 17:28:32 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.199 X-Spam-Level: X-Spam-Status: No, score=-1.199 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id q5WZ1RkHyIm4 for ; Thu, 26 Jan 2017 17:28:30 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id DE93760D97 for ; Thu, 26 Jan 2017 17:28:27 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1F8E4E040C for ; Thu, 26 Jan 2017 17:28:26 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id D1B182529D for ; Thu, 26 Jan 2017 17:28:24 +0000 (UTC) Date: Thu, 26 Jan 2017 17:28:24 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17515) Reduce memory footprint of RegionLoads kept by StochasticLoadBalancer MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 26 Jan 2017 17:28:34 -0000 [ https://issues.apache.org/jira/browse/HBASE-17515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15840097#comment-15840097 ] stack commented on HBASE-17515: ------------------------------- I try to follow your reasoning: + You leave out class overhead. And aren't you supposed to multiple by 15, the number of regions to keep around? (Thats what I did). Regardless, you don't answer the question which is is 24MB (or 24MB * 15) too much data to keep around for sake of a single metric? + You make some soft argument about 'good practice' cutting down memory in general but no work to show how this here is even a problem area in master memory management. + I ask if rather than do our own accounting, we should not defer to package and you turn the question around to have me do the work (Since you ask, Data Sketches, a stochastic streaming algorithms library looks promising especially as we need to start using it throughout) + You then pervert my general shaving of RL size question into a query about the four fields extracted here. Please provide our gracious contributors with better quality input/direction. > Reduce memory footprint of RegionLoads kept by StochasticLoadBalancer > --------------------------------------------------------------------- > > Key: HBASE-17515 > URL: https://issues.apache.org/jira/browse/HBASE-17515 > Project: HBase > Issue Type: Improvement > Reporter: Ted Yu > Assignee: Tim Brown > Fix For: 2.0.0, 1.4.0 > > Attachments: 17515.branch-1.v2.txt, 17515.v1.txt, 17515.v2.txt > > > Currently StochasticLoadBalancer uses the following fields of RegionLoad : > {code} > return rl.getReadRequestsCount(); > return rl.getWriteRequestsCount(); > return rl.getMemStoreSizeMB(); > return rl.getStorefileSizeMB(); > {code} > However, RegionLoad refers to ClusterStatusProtos.RegionLoad which has 18 fields. > This means we keep hbase.master.balancer.stochastic.numRegionLoadsToRemember (default value 15) RegionLoad's in memory but only use a small portion of them. > This JIRA is to consider creating POJO which wraps the above 4 fields so that the memory footprint can be lowered. > Lowering memory footprint would allow wider sliding window to be configured for load balancer while limiting the impact to heap consumption. -- This message was sent by Atlassian JIRA (v6.3.4#6332)