Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B807C200C02 for ; Fri, 20 Jan 2017 19:36:32 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B35B7160B34; Fri, 20 Jan 2017 18:36:32 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0B942160B48 for ; Fri, 20 Jan 2017 19:36:31 +0100 (CET) Received: (qmail 41994 invoked by uid 500); 20 Jan 2017 18:36:31 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 41982 invoked by uid 99); 20 Jan 2017 18:36:31 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Jan 2017 18:36:31 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B61FC181B9D for ; Fri, 20 Jan 2017 18:36:30 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.199 X-Spam-Level: X-Spam-Status: No, score=-1.199 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id JyRfdl0Ru0kJ for ; Fri, 20 Jan 2017 18:36:30 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 5133C5FC2F for ; Fri, 20 Jan 2017 18:36:29 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 55204E0248 for ; Fri, 20 Jan 2017 18:36:28 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3E90F25286 for ; Fri, 20 Jan 2017 18:36:27 +0000 (UTC) Date: Fri, 20 Jan 2017 18:36:27 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17489) ClientScanner may send a next request to a RegionScanner which has been exhausted MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 20 Jan 2017 18:36:32 -0000 [ https://issues.apache.org/jira/browse/HBASE-17489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832225#comment-15832225 ] stack commented on HBASE-17489: ------------------------------- Tried to review. I don't have much to contribute. It is hard to follow what is going on. The patch makes valiant effort and trying to clean up. I'd say commit if it passes all tests. Nice fix saving an RPC per scan. > ClientScanner may send a next request to a RegionScanner which has been exhausted > --------------------------------------------------------------------------------- > > Key: HBASE-17489 > URL: https://issues.apache.org/jira/browse/HBASE-17489 > Project: HBase > Issue Type: Bug > Components: Client, scan > Affects Versions: 2.0.0, 1.3.0, 1.4.0 > Reporter: Duo Zhang > Assignee: Duo Zhang > Priority: Critical > Fix For: 2.0.0, 1.4.0, 1.3.1 > > Attachments: HBASE-17489.patch, HBASE-17489-v1.patch, HBASE-17489-v2.patch, HBASE-17489-v3.patch, HBASE-17489-v4.patch, HBASE-17489-v4.patch > > > Found it when implementing HBASE-17045. Seems the final result of the scan is correct but no doubt the logic is broken. We need to fix it to stop things get worse in the future. -- This message was sent by Atlassian JIRA (v6.3.4#6332)