Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 9 Jan 2017 21:39:58 +0000 (UTC)
From: "Lars Hofhansl (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13033187.1483997776000.689735.1483997998741@Atlassian.JIRA>
In-Reply-To: <JIRA.13033187.1483997776000@Atlassian.JIRA>
References: <JIRA.13033187.1483997776000@Atlassian.JIRA> <JIRA.13033187.1483997776202@arcas>
Subject: [jira] [Updated] (HBASE-17440) [0.98] Make sure DelayedClosing
 chore is stopped as soon as an HConnection is closed
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 09 Jan 2017 21:40:01 -0000


     [ https://issues.apache.org/jira/browse/HBASE-17440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Hofhansl updated HBASE-17440:
----------------------------------
    Attachment: 17440.txt

Here's the trivial fix, just trigger the chore immediately if the connection is stopped, the chore will then determine that its connection is shutdown and end itself.
I tested this, I was not able to build up 1000's of DelayedClosing threads in a tight loop.

(as said, this is not the main issue we've been seeing, but something I noticed on the way)

Please have a look. [~apurtell], fyi.

> [0.98] Make sure DelayedClosing chore is stopped as soon as an HConnection is closed
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-17440
>                 URL: https://issues.apache.org/jira/browse/HBASE-17440
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.24
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>         Attachments: 17440.txt
>
>
> We're seeing many issue with run-away ZK client connection in long running app servers. 10k or more send or event threads are happening frequently.
> While I looked around in the code I noticed that DelayedClosing closing is not immediately ended when an HConnection is closed, when there's an issue with HBase or ZK and client reconnect in a tight loop, this can lead temporarily to very many threads running. These will all get cleaned out after at most 60s, but during that time a lot of threads can be created.
> The fix is a one-liner. We'll likely file other issues soon.
> Interestingly branch-1 and beyond do not have this chore anymore, although - at least in branch-1 and later - I still see the ZooKeeperAliveConnection.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)