Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 58C55200C2D for ; Sat, 28 Jan 2017 00:09:31 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 577A1160B5B; Fri, 27 Jan 2017 23:09:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AB6E7160B5C for ; Sat, 28 Jan 2017 00:09:30 +0100 (CET) Received: (qmail 19462 invoked by uid 500); 27 Jan 2017 23:09:29 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 19439 invoked by uid 99); 27 Jan 2017 23:09:29 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Jan 2017 23:09:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 42E7718C8C9 for ; Fri, 27 Jan 2017 23:09:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.199 X-Spam-Level: X-Spam-Status: No, score=-1.199 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id T5ZpEjR-izCu for ; Fri, 27 Jan 2017 23:09:28 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 076985FE1E for ; Fri, 27 Jan 2017 23:09:28 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A5CAAE04B5 for ; Fri, 27 Jan 2017 23:09:25 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id D62242528B for ; Fri, 27 Jan 2017 23:09:24 +0000 (UTC) Date: Fri, 27 Jan 2017 23:09:24 +0000 (UTC) From: "Zach York (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17437) Support specifying a WAL directory outside of the root directory MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 27 Jan 2017 23:09:31 -0000 [ https://issues.apache.org/jira/browse/HBASE-17437?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D158= 43630#comment-15843630 ]=20 Zach York commented on HBASE-17437: ----------------------------------- [~enis] [~stack] Thanks for the reviews. I will update the patch today. Als= o, thanks for explaining the fs redo project. I would love to help with tha= t effort (and try to get some of it out by HBase 2.0 if I have some good re= viewers ;) ).=20 I have been thinking about moving everything to HFileSystem and have a coup= le approaches: 1) Naive approach: Move the getWALRootDirectory() and getWALFileSystem() to= HFileSystem and use them as they are being used right now. This way is error-prone because people can forget to use the right FileSyst= em in their changes (after this change) and break things. 2) Intelligent approach: Have HFileSystem override all the methods from Fil= eSystem and ensure that the correct FileSystem is used based off of the sch= eme. This way is much better, but might incur a small performance loss (should b= e negligible though). What do you guys think? I will be implementing approach 1 to move complete this JIRA, but then woul= d like to do approach 2 in a follow-up JIRA. > Support specifying a WAL directory outside of the root directory > ---------------------------------------------------------------- > > Key: HBASE-17437 > URL: https://issues.apache.org/jira/browse/HBASE-17437 > Project: HBase > Issue Type: Improvement > Components: Filesystem Integration, wal > Affects Versions: 1.2.4 > Reporter: Yishan Yang > Assignee: Zach York > Labels: patch > Fix For: 2.0.0, 1.4.0 > > Attachments: hbase-17437-branch-1.2.patch, HBASE-17437.master.001= .patch, HBASE-17437.master.002.patch, HBASE-17437.master.003.patch, HBASE-1= 7437.master.004.patch, hbase-17437-master.patch > > > Currently, the WAL and the StoreFiles need to be on the same FileSystem. = Some FileSystems (such as Amazon S3) don=E2=80=99t support append or consis= tent writes. These two properties are imperative for the WAL in order to av= oid loss of writes. However, StoreFiles don=E2=80=99t necessarily need the = same consistency guarantees (since writes are cached locally and if writes = fail, they can always be replayed from the WAL). > =20 > This JIRA aims to allow users to configure a log directory (for WALs) tha= t is outside of the root directory or even in a different FileSystem. The d= efault value will still put the log directory under the root directory. -- This message was sent by Atlassian JIRA (v6.3.4#6332)