Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 10 Jan 2017 03:42:58 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13032473.1483681792000.692616.1484019778720@Atlassian.JIRA>
In-Reply-To: <JIRA.13032473.1483681792000@Atlassian.JIRA>
References: <JIRA.13032473.1483681792000@Atlassian.JIRA> <JIRA.13032473.1483681792279@arcas>
Subject: [jira] [Commented] (HBASE-17431) Incorrect precheck condition in
 RoundRobinPool#get()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 10 Jan 2017 03:43:00 -0000


    [ https://issues.apache.org/jira/browse/HBASE-17431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15813753#comment-15813753 ] 

Ted Yu commented on HBASE-17431:
--------------------------------

Jan:
More investigation is needed.

Let me know if you need help.

> Incorrect precheck condition in RoundRobinPool#get()
> ----------------------------------------------------
>
>                 Key: HBASE-17431
>                 URL: https://issues.apache.org/jira/browse/HBASE-17431
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Jan Hentschel
>            Priority: Minor
>         Attachments: HBASE-17431.master.001.patch, HBASE-17431.master.002.patch
>
>
> Here is related code:
> {code}
>     public R get() {
>       if (super.size() < maxSize) {
>         return null;
>       }
>       nextResource %= super.size();
> {code}
> Since super.size() is involved in modulo operation after the check, it seems the check should compare against 0 instead of maxSize.
> Looks like a copy-paste error from put() method.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)