Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 17 Jan 2017 21:20:26 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13030979.1482969899000.32364.1484688026689@Atlassian.JIRA>
In-Reply-To: <JIRA.13030979.1482969899000@Atlassian.JIRA>
References: <JIRA.13030979.1482969899000@Atlassian.JIRA> <JIRA.13030979.1482969899680@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-17387) Reduce the overhead of exception
 report in RegionActionResult for multi()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 17 Jan 2017 21:20:32 -0000


    [ https://issues.apache.org/jira/browse/HBASE-17387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826837#comment-15826837 ] 

Hudson commented on HBASE-17387:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-1.3-JDK8 #95 (See [https://builds.apache.org/job/HBase-1.3-JDK8/95/])
HBASE-17387 Reduce the overhead of exception report in (tedyu: rev eb19a67486e1d722ce2f9d3484c0a7b111438d43)
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java


> Reduce the overhead of exception report in RegionActionResult for multi()
> -------------------------------------------------------------------------
>
>                 Key: HBASE-17387
>                 URL: https://issues.apache.org/jira/browse/HBASE-17387
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>             Fix For: 2.0.0, 1.4.0, 1.3.1
>
>         Attachments: 17387.v1.txt, 17387.v2.txt, 17387.v3.txt
>
>
> For RSRpcServices#doNonAtomicRegionMutation() :
> {code}
>     for (ClientProtos.Action action: actions.getActionList()) {
> ...
>       } catch (IOException ie) {
>         rpcServer.getMetrics().exception(ie);
>         resultOrExceptionBuilder = ResultOrException.newBuilder().
>           setException(ResponseConverter.buildException(ie));
>       }
>       if (resultOrExceptionBuilder != null) {
>         // Propagate index.
>         resultOrExceptionBuilder.setIndex(action.getIndex());
>         builder.addResultOrException(resultOrExceptionBuilder.build());
>       }
> {code}
> The exceptions are added to builder in the for loop.
> The ClientProtos.ResultOrException.Builder instance is created within the for loop.
> For large multi call, this may incur non-trivial overhead for garbage collector if there're many exceptions.
> e.g. Here was sample debug log showing the actions in a batch:
> {code}
> 2016-12-23 04:21:56,263 DEBUG org.apache.hadoop.hbase.regionserver.RSRpcServices: NonAtomicRegionMutation batch summary: numAppends=0, numDeletes=11, numGets=0, numIncrements=15638, numPuts=15627, numServiceCalls=0, serializedSize=3871713, user=hbase/pob3.G.COM (auth:KERBEROS), client=null
> {code}
> Note the large number of increments in the batch.
> When the increments encounter conflict at server side, the overhead of stringified exceptions in response is considerable.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)