Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7C2CF200BF1 for ; Tue, 3 Jan 2017 11:57:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 7AEC0160B33; Tue, 3 Jan 2017 10:57:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C092D160B43 for ; Tue, 3 Jan 2017 11:56:59 +0100 (CET) Received: (qmail 10749 invoked by uid 500); 3 Jan 2017 10:56:58 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 10481 invoked by uid 99); 3 Jan 2017 10:56:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jan 2017 10:56:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 8D8FA2C2A6B for ; Tue, 3 Jan 2017 10:56:58 +0000 (UTC) Date: Tue, 3 Jan 2017 10:56:58 +0000 (UTC) From: "Yu Li (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17372) Make AsyncTable thread safe MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 03 Jan 2017 10:57:00 -0000 [ https://issues.apache.org/jira/browse/HBASE-17372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15794779#comment-15794779 ] Yu Li commented on HBASE-17372: ------------------------------- Thanks for the ping [~Apache9]. The latest v3 patch lgtm, good clean up, +1. Maybe we should mention the newly added OperationConfig in description and add some release note talking about how to set the (bunch of) timeout configurations? In current stable releases we mainly use three timeouts: hbase.rpc.timeout for each RPC, hbase.client.operation.timeout for all operations but scan, and hbase.client.scanner.timeout.period for scan; And in 2.0 we've added hbase.rpc.read.timeout and hbase.rpc.write.timeout. However, I failed to find any detailed doc in our hbase book (please refer me to it if any, thanks), so maybe this is a good chance to add it (smile). > Make AsyncTable thread safe > --------------------------- > > Key: HBASE-17372 > URL: https://issues.apache.org/jira/browse/HBASE-17372 > Project: HBase > Issue Type: Sub-task > Components: asyncclient, Client > Affects Versions: 2.0.0 > Reporter: Duo Zhang > Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: HBASE-17372-v1.patch, HBASE-17372-v2.patch, HBASE-17372-v3.patch, HBASE-17372.patch > > > The most methods are already thread safe. The problem is that we have some methods that used to set timeout, we need to remove these methods and add a parameter for each call to specific timeout settings. -- This message was sent by Atlassian JIRA (v6.3.4#6332)