Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 67EDB200C04 for ; Mon, 9 Jan 2017 12:21:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 66859160B3B; Mon, 9 Jan 2017 11:21:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B00DA160B49 for ; Mon, 9 Jan 2017 12:20:59 +0100 (CET) Received: (qmail 91116 invoked by uid 500); 9 Jan 2017 11:20:58 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 91040 invoked by uid 99); 9 Jan 2017 11:20:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Jan 2017 11:20:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 85DE42C2A6B for ; Mon, 9 Jan 2017 11:20:58 +0000 (UTC) Date: Mon, 9 Jan 2017 11:20:58 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17291) Remove ImmutableSegment#getKeyValueScanner MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 09 Jan 2017 11:21:00 -0000 [ https://issues.apache.org/jira/browse/HBASE-17291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15811518#comment-15811518 ] Hudson commented on HBASE-17291: -------------------------------- FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #2286 (See [https://builds.apache.org/job/HBase-Trunk_matrix/2286/]) HBASE-17291 Remove ImmutableSegment#getKeyValueScanner (Ram) (ramkrishna: rev f65a439f0188c0811c2ca07b5d830498809a13ab) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SegmentScanner.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStoreChunkPool.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreSnapshot.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ImmutableSegment.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactingToCellArrayMapMemStore.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactingMemStore.java * (add) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SnapshotScanner.java > Remove ImmutableSegment#getKeyValueScanner > ------------------------------------------ > > Key: HBASE-17291 > URL: https://issues.apache.org/jira/browse/HBASE-17291 > Project: HBase > Issue Type: Improvement > Components: Scanners > Affects Versions: 2.0.0 > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0 > > Attachments: HBASE-17291.patch, HBASE-17291_1.patch, HBASE-17291_2.patch, HBASE-17291_3.patch > > > This is based on a discussion over [~anastas]'s patch. The MemstoreSnapshot uses a KeyValueScanner which actually seems redundant considering we already have a SegmentScanner. The idea is that the snapshot scanner should be a simple iterator type of scanner but it lacks the capability to do the reference counting on that segment that is now used in snapshot. With snapshot having mulitple segments in the latest impl it is better we hold on to the segment by doing ref counting. -- This message was sent by Atlassian JIRA (v6.3.4#6332)