Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 26 Jan 2017 03:47:26 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13026849.1481247188000.208841.1485402446592@Atlassian.JIRA>
In-Reply-To: <JIRA.13026849.1481247188000@Atlassian.JIRA>
References: <JIRA.13026849.1481247188000@Atlassian.JIRA> <JIRA.13026849.1481247188674@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-17280) Add mechanism to control hbase
 cleaner behavior
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 26 Jan 2017 03:47:31 -0000


    [ https://issues.apache.org/jira/browse/HBASE-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839138#comment-15839138 ] 

Ted Yu commented on HBASE-17280:
--------------------------------

Other than log cleaner and hfile cleaner, there're the following in HMaster:
{code}
  private ReplicationMetaCleaner replicationMetaCleaner;
  private ReplicationZKNodeCleanerChore replicationZKNodeCleanerChore;
  private ExpiredMobFileCleanerChore expiredMobFileCleanerChore;
{code}
Why were they excluded from the the runCleaner() method ?

For setCleanerRunning():
{code}
+        .setPrevValue(
+            master.getLogCleaner().setEnabled(req.getOn())
+                && master.getHFileCleaner().setEnabled(req.getOn())).build();
{code}
If either log cleaner or hfile cleaner was previously disabled (and request being to enable), the return value would be false. However, shouldn't the caller to this method know which cleaner was disabled ?


> Add mechanism to control hbase cleaner behavior
> -----------------------------------------------
>
>                 Key: HBASE-17280
>                 URL: https://issues.apache.org/jira/browse/HBASE-17280
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client, hbase, shell
>    Affects Versions: 2.0.0, 1.2.0
>            Reporter: Ajay Jadhav
>            Priority: Minor
>             Fix For: 2.0.0, 1.2.0
>
>         Attachments: HBASE-17280.branch-1.2.patch, HBASE-17280.branch-2.0.patch, HBASE-17280.v1-branch-1.2.patch, HBASE-17280.v2-branch-1.2.patch, HBASE-17280.v2-branch-2.patch
>
>
> Cleaner is used to get rid of archived HFiles and old WALs in HBase.
> In the case of heavy workload, cleaner can affect query performance by creating a lot of connections to perform costly reads/ writes against underlying filesystem.
> This patch allows the user to control HBase cleaner behavior by providing shell commands to enable/ disable and manually run it.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)