Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 492D9200C16 for ; Thu, 26 Jan 2017 05:39:32 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 47D0D160B4E; Thu, 26 Jan 2017 04:39:32 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8F8C2160B5A for ; Thu, 26 Jan 2017 05:39:31 +0100 (CET) Received: (qmail 37331 invoked by uid 500); 26 Jan 2017 04:39:30 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 37320 invoked by uid 99); 26 Jan 2017 04:39:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Jan 2017 04:39:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 55E9CC2B3B for ; Thu, 26 Jan 2017 04:39:30 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.199 X-Spam-Level: X-Spam-Status: No, score=-1.199 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 2msmBQoRnMQd for ; Thu, 26 Jan 2017 04:39:29 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id DE5D85FC67 for ; Thu, 26 Jan 2017 04:39:28 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 11A0DE04A6 for ; Thu, 26 Jan 2017 04:39:28 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id A8CAD2529E for ; Thu, 26 Jan 2017 04:39:26 +0000 (UTC) Date: Thu, 26 Jan 2017 04:39:26 +0000 (UTC) From: "Jingcheng Du (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (HBASE-16812) Clean up the locks in MOB MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 26 Jan 2017 04:39:32 -0000 [ https://issues.apache.org/jira/browse/HBASE-16812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839141#comment-15839141 ] Jingcheng Du edited comment on HBASE-16812 at 1/26/17 4:39 AM: --------------------------------------------------------------- Thanks [~huaxiang]. A pre-check (check if the current partition is expired) is added before the compaction on a partition. If a compaction is in progress when the cleaner cleans expired mob files, I think it is okay to allow that partition to fail in FNFE and compaction on that partition is not necessary anymore. The only impact is the whole compaction is failed but all the other partitions can run successfully. I am also okay to add the lock back in cleaner. How do you think on this? Thanks! was (Author: jingcheng.du): Thanks [~huaxiang]. A pre-check (check if the current partition is expired) is added before the compaction on a partition. If a compaction is in progress when the cleaner cleans expired mob files, I think it is okay to allow that partition to fail in FNFE and compaction on that partition is not necessary anymore. The only impact is the whole compaction is failed but all the other partitions can run successfully. How do you think on this? Thanks! > Clean up the locks in MOB > ------------------------- > > Key: HBASE-16812 > URL: https://issues.apache.org/jira/browse/HBASE-16812 > Project: HBase > Issue Type: Task > Reporter: Appy > Assignee: Jingcheng Du > Priority: Minor > Attachments: HBASE-16812.master.001.patch, HBASE-16812.patch > > > Clean up the locks in MOB. > # Retain all the delete markers in mob-enabled columns until they are expired. > # Remove the locks from major compaction of mob-enabled columns. -- This message was sent by Atlassian JIRA (v6.3.4#6332)