hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Appy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17537) Remove Queue#isAvailable() since we have waits/wakes after HBASE-17067
Date Wed, 25 Jan 2017 20:36:26 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838530#comment-15838530
] 

Appy commented on HBASE-17537:
------------------------------

verifying if it's true, looking at TableQueue#isAvailable()

> Remove Queue#isAvailable() since we have waits/wakes after HBASE-17067
> ----------------------------------------------------------------------
>
>                 Key: HBASE-17537
>                 URL: https://issues.apache.org/jira/browse/HBASE-17537
>             Project: HBase
>          Issue Type: Sub-task
>          Components: master, proc-v2
>            Reporter: Appy
>            Assignee: Appy
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17537.master.001.patch
>
>
> Earlier, run-queues could have empty queues or queues for which exclusive locks are already
taken. Thus poll() on table/server run-queue might have returned a Queue which didn't have
any valid procs to run.
> With wait/wake on exclusive locks doing {removeFrom|addTo}RunQueue and poll removing
queues when last element is removed, i think we can remove this function now.
> (am finding these things when working on a larger patch, but there are changes like this
which seem too critical to mess up, so am creating smaller focused patches for them).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message