hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17470) Remove merge region code from region server
Date Tue, 17 Jan 2017 15:00:33 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826174#comment-15826174

stack commented on HBASE-17470:

It is ok to remove dispatchMergingRegions w/o deprecation? DId that come in to master branch
only? Or is that the incompatible change we are talking about here?

In here we are removing MergeRegionsRequest. Were these added by HBASE-16119 ? i.e. only in
master branch so safe to remove them?

We deprecate CP methods. There are others to use in stead?   In the deprecate message you
want to point folks at what to use in their place?

Ditto on what to use in stead of dispatchMergingRegions?

Is that right in HMaster? YOu remove dispatchMergingRegions... Does that make the deprecations

Otherwise patch looks good. Needs release note pointing at justification for the incompatible
change and what users need to use instead doing merges.

Is there any test of region merge in code base now given how much is removed here?

Looks good [~syuanjiang]

> Remove merge region code from region server
> -------------------------------------------
>                 Key: HBASE-17470
>                 URL: https://issues.apache.org/jira/browse/HBASE-17470
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>    Affects Versions: 2.0.0
>            Reporter: Stephen Yuan Jiang
>            Assignee: Stephen Yuan Jiang
>             Fix For: 2.0.0
>         Attachments: HBASE-17470.v1-master.patch, HBASE-17470.v2-master.patch
> HBASE-16119 moves the merge region to the master-side.  There is no need to keep region_server-side
merge region code to remove logic duplication.  
> util.Merge and HMerge tools depends on RS-side merge region logic.  However, now we can
merge regions using shell command.  It is dangerous to do offline merge.  For 2.0, it is a
good time to remove those out-of-date tools.   

This message was sent by Atlassian JIRA

View raw message