hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17437) Support specifying a WAL directory outside of the root directory
Date Sat, 07 Jan 2017 18:29:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15807936#comment-15807936
] 

Ted Yu commented on HBASE-17437:
--------------------------------

The following is repeated for HBASE_DIR_PERMS and HBASE_LOG_DIR_PERMS :
{code}
+  /** Parameter name for HBase instance log directory permission*/
{code}
Please differentiate between the two.
{code}
+    <name>hbase.regionserver.hlog.dir.perms</name>
+    <value>700</value>
+    <description>FS Permissions for the log directory in a secure(kerberos) setup.
+      When master starts, it creates the logdir with this permissions or sets the permissions
{code}
Permission for region server hlog dir is set by master ?

For MasterFileSystem.java :
{code}
+  // root log directory on the FS
   private final Path rootdir;

+  // root hbase directory on the FS
+  private final Path logRootDir;
{code}
The comments don't seem to match the variable names. Consider putting declaration of logRootDir
close to that for logFs.

For TestHRegionServerBulkLoadWithLogDir, add license header
It should be annotated with LargeTests
{code}
+        assertEquals("Expect 2 logs in oldWALs dir", 2, getWALFiles(logFs, new Path(logRootDir,
HConstants.HREGION_OLDLOGDIR_NAME)).size());
+        assertEquals("Expect 1 logs in WALs dir", 1, getWALFiles(logFs, new Path(logRootDir,
HConstants.HREGION_LOGDIR_NAME)).size());
{code}
Wrap long lines. "1 logs" -> "1 log"


> Support specifying a WAL directory outside of the root directory
> ----------------------------------------------------------------
>
>                 Key: HBASE-17437
>                 URL: https://issues.apache.org/jira/browse/HBASE-17437
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.2.4
>            Reporter: Yishan Yang
>              Labels: patch
>             Fix For: 2.0.0, 1.2.5
>
>         Attachments: hbase-17437-branch-1.2.patch, hbase-17437-master.patch
>
>
> Currently, the WAL and the StoreFiles need to be on the same FileSystem. Some FileSystems
(such as Amazon S3) don’t support append or consistent writes. These two properties are
imperative for the WAL in order to avoid loss of writes. However, StoreFiles don’t necessarily
need the same consistency guarantees (since writes are cached locally and if writes fail,
they can always be replayed from the WAL).
>  
> This JIRA aims to allow users to configure a log directory (for WALs) that is outside
of the root directory or even in a different FileSystem. The default value will still put
the log directory under the root directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message