hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-17434) New Synchronization Scheme for Compaction Pipeline
Date Tue, 10 Jan 2017 03:49:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15813763#comment-15813763
] 

Anoop Sam John edited comment on HBASE-17434 at 1/10/17 3:49 AM:
-----------------------------------------------------------------

In RB, I asked one Q regarding doing a version++ newly in the patch..  Pls correct me if I
read it wrong.
{code}
swapSuffix(suffix, segment, closeSuffix);
133	      readOnlyCopy = new LinkedList<>(pipeline);
134	      version++;
{code}
This one where swapSuffix is doing a version++ within it and we newly added it again here..


was (Author: anoop.hbase):
In RB, I asked one Q regarding doing a version++ newly in the patch..  Pls correct me if I
read it wrong.

> New Synchronization Scheme for Compaction Pipeline
> --------------------------------------------------
>
>                 Key: HBASE-17434
>                 URL: https://issues.apache.org/jira/browse/HBASE-17434
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Eshcar Hillel
>            Assignee: Eshcar Hillel
>         Attachments: HBASE-17434-V01.patch, HBASE-17434-V02.patch, HBASE-17434-V03.patch,
HBASE-17434.master.001.patch
>
>
> A new copyOnWrite synchronization scheme is introduced for the compaction pipeline.
> The new scheme is better since it removes the lock from getSegments() which is invoked
in every get and scan operation, and it reduces the number of LinkedList objects that are
created at runtime, thus can reduce GC (not by much, but still...).
> In addition, it fixes the method getTailSize() in compaction pipeline. This method creates
a MemstoreSize object which comprises the data size and the overhead size of the segment and
needs to be atomic.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message