hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17431) Incorrect precheck condition in RoundRobinPool#get()
Date Fri, 06 Jan 2017 20:12:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15805621#comment-15805621
] 

Ted Yu commented on HBASE-17431:
--------------------------------

TestPoolMap is in hbase-server module which was not run by QA.
TestPoolMap fails with the change.

Reverting.

> Incorrect precheck condition in RoundRobinPool#get()
> ----------------------------------------------------
>
>                 Key: HBASE-17431
>                 URL: https://issues.apache.org/jira/browse/HBASE-17431
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Jan Hentschel
>            Priority: Minor
>             Fix For: 2.0.0, 1.4.0
>
>         Attachments: HBASE-17431.master.001.patch, HBASE-17431.master.002.patch
>
>
> Here is related code:
> {code}
>     public R get() {
>       if (super.size() < maxSize) {
>         return null;
>       }
>       nextResource %= super.size();
> {code}
> Since super.size() is involved in modulo operation after the check, it seems the check
should compare against 0 instead of maxSize.
> Looks like a copy-paste error from put() method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message