hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eshcar Hillel (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17373) Reverse the order of snapshot creation in the CompactingMemStore
Date Wed, 04 Jan 2017 08:15:59 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797549#comment-15797549
] 

Eshcar Hillel commented on HBASE-17373:
---------------------------------------

[~ram_krish] I think you now have good understanding of the flow.
Removing the tail from the pipeline happens only every once in a while, and obviously traversing
the list will have no impact on performance in this case.
My view is that in this case having a more robust, easy to maintain code (which is the case
when re-using code) outweighs the potential local optimization. 

> Reverse the order of snapshot creation in the CompactingMemStore
> ----------------------------------------------------------------
>
>                 Key: HBASE-17373
>                 URL: https://issues.apache.org/jira/browse/HBASE-17373
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Anastasia Braginsky
>            Assignee: Eshcar Hillel
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17373-V01.patch, HBASE-17373-V02.patch, HBASE-17373-V03.patch,
HBASE-17373-V04.patch, HBASE-17373-V04.patch, HBASE-17373-V05.patch
>
>
> In CompactingMemStore both in BASIC and EAGER cases when snapshot is created the segments
are first removed from the pipeline then added to the snapshot. This is the opposite to what
is done in the DefaultMemStore where the snapshot is firstly created with the active segment
and only after the active segment is refreshed. This JIRA is about to reverse the order in
CompactingMemStore and to make all MemStores to behave the same.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message