hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duo Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17372) Make AsyncTable thread safe
Date Wed, 04 Jan 2017 04:17:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797114#comment-15797114
] 

Duo Zhang commented on HBASE-17372:
-----------------------------------

{quote}
What is happening in AsyncConnectionConfiguration? We are setting rpc timeout, rpc read timeout
and rpc write timeout but we only have a getRpcTimeoutNs?
{quote}
I think we already have the getXXXRpcTimeoutNs methods for AsyncConnectionConfiguration? I
just add a new getRpcTimeoutNs method.

{quote}
Should I get the builder on the OperationConfig obect rather than AsyncTableBase?
OperationConfigBuilder newOperationConfig();
It could take a configuration when you ask for the builder so you can set deafaults.
{quote}

AsyncConnectionConfiguration is not public and if we just pass a {{Configuration}} to it then
we need to get the configurations everytime using getInt or getLong when constructing a OperationConfigBuilder.
And one more thing is that we hae different operation timeout for meta table and other table,
which means we need to know the table name if we want to set defaults to OperationConfigBuilder.

> Make AsyncTable thread safe
> ---------------------------
>
>                 Key: HBASE-17372
>                 URL: https://issues.apache.org/jira/browse/HBASE-17372
>             Project: HBase
>          Issue Type: Sub-task
>          Components: asyncclient, Client
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17372-v1.patch, HBASE-17372-v2.patch, HBASE-17372-v3.patch,
HBASE-17372.patch
>
>
> The most methods are already thread safe. The problem is that we have some methods that
used to set timeout, we need to remove these methods and add a parameter for each call to
specific timeout settings.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message