hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17372) Make AsyncTable thread safe
Date Tue, 03 Jan 2017 22:57:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796469#comment-15796469
] 

Enis Soztutar commented on HBASE-17372:
---------------------------------------

Do we really need the OperationConfig to be specified per-operation? I was thinking that the
approach we went with the Connection / Table separation is a good boundary for specifying
different timeout configs. Since Table is a cheap object, you can have different Table objects
with different timeouts, and use it, no? 

So the overall usage would be like: 
{code}
 Connection -> configured via hbase-site.xml 
 Table t1 = Connection.getTable() 
 t1.setRpcTimeout(foo); 
 t1.get() // etc 
 Table t2 = Connection.getTable() 
 t2.setRpcTimeout(bar); 
 t2.put() 
{code}

So in that sense, I was thinking the Table/AsyncTable to be the "OperationConfiguration" object
for multiple operations. 

> Make AsyncTable thread safe
> ---------------------------
>
>                 Key: HBASE-17372
>                 URL: https://issues.apache.org/jira/browse/HBASE-17372
>             Project: HBase
>          Issue Type: Sub-task
>          Components: asyncclient, Client
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17372-v1.patch, HBASE-17372-v2.patch, HBASE-17372-v3.patch,
HBASE-17372.patch
>
>
> The most methods are already thread safe. The problem is that we have some methods that
used to set timeout, we need to remove these methods and add a parameter for each call to
specific timeout settings.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message