hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17346) Add coprocessor service support
Date Thu, 26 Jan 2017 08:12:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839405#comment-15839405
] 

stack commented on HBASE-17346:
-------------------------------

A few notes on the patch:

Is it a ClientCoprocessorRpcController ? There is nothing 'coprocessory' about it. It is RpcController
Interface with default implementations. Maybe call it something more generic? Might be useful
in other than CP.

Yeah, I'm still a bit baffled on the functional additions to do CPs but that is my fault not
yours... Let me look further down the patch to see how they are used.

TestAsyncAggregationClient looks nice and clean.  AsyncAggregationClient I need to study more
(smile).



> Add coprocessor service support
> -------------------------------
>
>                 Key: HBASE-17346
>                 URL: https://issues.apache.org/jira/browse/HBASE-17346
>             Project: HBase
>          Issue Type: Sub-task
>          Components: asyncclient, Client, Coprocessors
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0
>
>         Attachments: 17346.suggestion.txt, HBASE-17346.patch, HBASE-17346-v1.patch, HBASE-17346-v2.patch
>
>
> I think we need to redesign the API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message