hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17346) Add coprocessor service support
Date Sat, 28 Jan 2017 06:22:24 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843917#comment-15843917
] 

stack commented on HBASE-17346:
-------------------------------

Reviewed the patch. I can follow it better now. 

Do s/done/callback/g I'd say. 'done' I don't get when I see it in your javadoc example. 'callback'
I can follow and 'callback' makes it look like a protobuf service invocation.

When you say this...

.bq i.e, there will be no {@link #onRegionComplete(HRegionInfo, Object)} calls anymore.

Have we shipped a client that does onRegionComplete callback? If not, strike this. It only
confuses.

Javadoc talks of whenComplete and onComplete?

We have onRegionComplete and onComplete in the Interface but onRegionComplete is not called
any more? Or if onRegionComplete, then it happens when we are totally done with the region?

Sorry to fixate on the API and the doc. I think it important to get this bit clear (and it
is tough because what is going on here is a bit voodoo and magical at same time). Thanks Duo.

[~ghelmling] FYI You might be interested in this spin on your original EndpointCP work sir.



> Add coprocessor service support
> -------------------------------
>
>                 Key: HBASE-17346
>                 URL: https://issues.apache.org/jira/browse/HBASE-17346
>             Project: HBase
>          Issue Type: Sub-task
>          Components: asyncclient, Client, Coprocessors
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0
>
>         Attachments: 17346.suggestion.txt, HBASE-17346.patch, HBASE-17346-v1.patch, HBASE-17346-v2.patch,
HBASE-17346-v3.patch
>
>
> I think we need to redesign the API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message