hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17278) [C++] Cell Scanner Implementation to be used by ResultScanner
Date Fri, 20 Jan 2017 03:22:26 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831106#comment-15831106
] 

Enis Soztutar commented on HBASE-17278:
---------------------------------------

Thanks Sudeep. 
I like the use of the Cursors for reading from the IOBufs. Searched around the docs, but could
not find a lot of examples. Did you see it anywhere, or you have read the code from folly?


For the CellScanner, I think we would like to keep it as independent of the "cells being serialized
in a buffer" concept. For example, Result object implements CellScanner in Java. In that terms,
fields like beyond_block_data_ should go in the KeyValueCodec class instead.  

The KVCodec should be able to also encode bunch of cells to a given IOBuf. We will need that
functionality when we are doing Puts, so we do not need that in this patch for now. However,
lets still have a Decoder inside the KVCodec and have the Decoding logic be inside the Decoder.
KVCoder.Decoder() will instantiate a decoder object. We'll add the Encoder later. 





> [C++] Cell Scanner Implementation to be used by ResultScanner
> -------------------------------------------------------------
>
>                 Key: HBASE-17278
>                 URL: https://issues.apache.org/jira/browse/HBASE-17278
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Sudeep Sunthankar
>            Assignee: Sudeep Sunthankar
>         Attachments: HBASE-17278.HBASE-14850.v1.patch, HBASE-17278.HBASE-14850.v2.patch,
HBASE-17278.HBASE-14850.v3.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message