hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17263) Netty based rpc server impl
Date Tue, 10 Jan 2017 23:26:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15816521#comment-15816521
] 

Ted Yu commented on HBASE-17263:
--------------------------------

For NettyRpcServer , check the state of closed at the beginning of stop().
{code}
    int workerCount = conf.getInt("hbase.rpc.server.netty.work.size", 12);
{code}
Name the parameter hbase.netty.rpc.server.worker.count
{code}
    } catch (InterruptedException e) {
      throw new IOException(e);
{code}
Throw InterruptedIOException.
{code}
        this.hostAddress = "*Unknown*";
{code}
Why the asterisk ?
There seems to be duplicate code (e.g. saslReadAndProcess()) with SimpleRpcServer#Connection.
Do you plan to refactor code in follow on JIRA ?

>   Netty based rpc server impl
> -----------------------------
>
>                 Key: HBASE-17263
>                 URL: https://issues.apache.org/jira/browse/HBASE-17263
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Performance, rpc
>            Reporter: binlijin
>            Assignee: binlijin
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17263.patch
>
>
> An RPC server with Netty4 implementation, which provide better performance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message