hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anastasia Braginsky (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17081) Flush the entire CompactingMemStore content to disk
Date Mon, 09 Jan 2017 12:31:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15811662#comment-15811662

Anastasia Braginsky commented on HBASE-17081:

As [~anoop.hbase] has mentioned I see both HBASE-17434 and HBASE-17379 are trying to improve
the synchronization of the CompactionPipeline.
I am going to comment on each of them separately, but without entering into the details of
each of the solutions, it is clear that such a "competition" is not a healthy way to move
toward our mutual goal which is *fast and correct HBase*.
We are all very valuable engineers and each can code some kind of solution that will work.
Let us join forces on one JIRA and make its solution acceptable on each of us.

Generally, just because Eshcar has written the CompactionPipeline code in the first place,
and she is very much aware about all CompactingMemStore synchronization invariants I would
take her solution as a base and I would make it till the satisfaction of all our concerns.
Her code is explained and open in the review board. We are here to review.

This is just my opinion of course, but this is how I see it from a side.

> Flush the entire CompactingMemStore content to disk
> ---------------------------------------------------
>                 Key: HBASE-17081
>                 URL: https://issues.apache.org/jira/browse/HBASE-17081
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Anastasia Braginsky
>            Assignee: Eshcar Hillel
>             Fix For: 2.0.0
>         Attachments: HBASE-15787_8.patch, HBASE-17081-V01.patch, HBASE-17081-V02.patch,
HBASE-17081-V03.patch, HBASE-17081-V04.patch, HBASE-17081-V05.patch, HBASE-17081-V06.patch,
HBASE-17081-V06.patch, HBASE-17081-V07.patch, HBASE-17081-V10.patch, HBaseMeetupDecember2016-V02.pptx,
> Part of CompactingMemStore's memory is held by an active segment, and another part is
divided between immutable segments in the compacting pipeline. Upon flush-to-disk request
we want to flush all of it to disk, in contrast to flushing only tail of the compacting pipeline.

This message was sent by Atlassian JIRA

View raw message