hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16812) Clean up the locks in MOB
Date Thu, 26 Jan 2017 07:10:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839351#comment-15839351

stack commented on HBASE-16812:

bq. A new tag is not necessary? I am thinking of using the existing ref tag for the delete
marker to implement this. How do you think? Thanks.

This sounds good [~jingcheng.du]. And thanks for clarification on comment in code. Makes sense

Patch looks good to me. Defer to [~huaxiang] on whether to bring back the lock around cleaner...
Might be cleaner... failed compactions might distress the poor old operator.

Nit: Do you want to write the Cell with the tag to the delFile? Or maybe it doesn't matter?

205	              delFileWriter.append(c);

Is this change right?

232	    @Override	232	    @Override
233	    public ScanType getScanType(CompactionRequest request) {	233	    public ScanType getScanType(CompactionRequest
request) {
234	      return request.isRetainDeleteMarkers() ? ScanType.COMPACT_RETAIN_DELETES		
235	          : ScanType.COMPACT_DROP_DELETES;	234	      return request.isAllFiles() ? ScanType.COMPACT_DROP_DELETES
235	          : ScanType.COMPACT_RETAIN_DELETES;

I like all the cleanup [~jingcheng.du] Thanks for working on this.

> Clean up the locks in MOB
> -------------------------
>                 Key: HBASE-16812
>                 URL: https://issues.apache.org/jira/browse/HBASE-16812
>             Project: HBase
>          Issue Type: Task
>            Reporter: Appy
>            Assignee: Jingcheng Du
>            Priority: Minor
>         Attachments: HBASE-16812.master.001.patch, HBASE-16812.patch, HBASE-16812-V2.patch
> Clean up the locks in MOB. 
> # Retain all the delete markers in mob-enabled columns until they are expired.
> # Remove the locks from major compaction of mob-enabled columns.

This message was sent by Atlassian JIRA

View raw message