hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "huaxiang sun (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16812) Clean up the locks in MOB
Date Wed, 25 Jan 2017 20:54:26 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838559#comment-15838559
] 

huaxiang sun commented on HBASE-16812:
--------------------------------------

Hi [~jingcheng.du], I think the patch looks good. I have one comment. With the patch, ExpiredMobFileCleanerChore
now does not need to acquire a read lock before removing expired files. While PartitionedMobCompactor
is compacting files, ExpiredMobFileCleanerChore could come in and remove files. This may cause
FileNotFoundException in PartitionedMobCompactor and it is not handled (compaction will fail).
Maybe it needs to handle this exception and do not abort the compaction? Thanks.

> Clean up the locks in MOB
> -------------------------
>
>                 Key: HBASE-16812
>                 URL: https://issues.apache.org/jira/browse/HBASE-16812
>             Project: HBase
>          Issue Type: Task
>            Reporter: Appy
>            Assignee: Jingcheng Du
>            Priority: Minor
>         Attachments: HBASE-16812.master.001.patch, HBASE-16812.patch
>
>
> Clean up the locks in MOB. 
> # Retain all the delete markers in mob-enabled columns until they are expired.
> # Remove the locks from major compaction of mob-enabled columns.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message