Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EEEF2200BEA for ; Tue, 27 Dec 2016 10:48:59 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id ED99D160B31; Tue, 27 Dec 2016 09:48:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 68D7F160B23 for ; Tue, 27 Dec 2016 10:48:59 +0100 (CET) Received: (qmail 60173 invoked by uid 500); 27 Dec 2016 09:48:58 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 60158 invoked by uid 99); 27 Dec 2016 09:48:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Dec 2016 09:48:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 72CDC2C1F54 for ; Tue, 27 Dec 2016 09:48:58 +0000 (UTC) Date: Tue, 27 Dec 2016 09:48:58 +0000 (UTC) From: "Duo Zhang (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17372) Make AsyncTable thread safe MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 27 Dec 2016 09:49:00 -0000 [ https://issues.apache.org/jira/browse/HBASE-17372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15780055#comment-15780055 ] Duo Zhang commented on HBASE-17372: ----------------------------------- For now the read timeout is for exists, scan and get, and write timeout is for all other operations. For batch, if a group only have Get then we use read timeout, if no Get then we use write timeout, if both then we will use the larger one. Agree that we'd better use a single rpc timeout as the user may not set the correct timeout, for example, set read timeout but calling checkAndPut. Then how do we deal with the default rpc timeout of batch? A new timeout config for batch? Then should multiGet, multiPut use the batch timeout? Yeah maybe we do not need to introduce so many rpc timeout configs as it could be changed per call now... > Make AsyncTable thread safe > --------------------------- > > Key: HBASE-17372 > URL: https://issues.apache.org/jira/browse/HBASE-17372 > Project: HBase > Issue Type: Sub-task > Components: asyncclient, Client > Affects Versions: 2.0.0 > Reporter: Duo Zhang > Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: HBASE-17372.patch > > > The most methods are already thread safe. The problem is that we have some methods that used to set timeout, we need to remove these methods and add a parameter for each call to specific timeout settings. -- This message was sent by Atlassian JIRA (v6.3.4#6332)