Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7E12D200C09 for ; Wed, 21 Dec 2016 07:07:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 7CA97160B29; Wed, 21 Dec 2016 06:07:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D24FE160B33 for ; Wed, 21 Dec 2016 07:06:59 +0100 (CET) Received: (qmail 74995 invoked by uid 500); 21 Dec 2016 06:06:58 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 74958 invoked by uid 99); 21 Dec 2016 06:06:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Dec 2016 06:06:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 949BE2C0086 for ; Wed, 21 Dec 2016 06:06:58 +0000 (UTC) Date: Wed, 21 Dec 2016 06:06:58 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17328) Properly dispose of looped replication peers MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 21 Dec 2016 06:07:00 -0000 [ https://issues.apache.org/jira/browse/HBASE-17328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766237#comment-15766237 ] Hudson commented on HBASE-17328: -------------------------------- SUCCESS: Integrated in Jenkins build HBase-1.4 #574 (See [https://builds.apache.org/job/HBase-1.4/574/]) HBASE-17328 Properly dispose of looped replication peers (apurtell: rev e79afbf0cbca95ed4dad67ef83d9755c86629a85) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestMasterReplication.java > Properly dispose of looped replication peers > -------------------------------------------- > > Key: HBASE-17328 > URL: https://issues.apache.org/jira/browse/HBASE-17328 > Project: HBase > Issue Type: Bug > Components: Replication > Affects Versions: 2.0.0, 1.4.0, 0.98.23 > Reporter: Vincent Poon > Assignee: Vincent Poon > Priority: Critical > Fix For: 2.0.0, 1.3.0, 1.4.0, 1.2.5, 0.98.24, 1.1.9 > > Attachments: HBASE-17328-1.1.v1.patch, HBASE-17328-master.v1.patch, HBASE-17328-master.v2.patch, HBASE-17328.0.98.v4.patch, HBASE-17328.branch-1.1.v2.patch, HBASE-17328.branch-1.1.v3.patch, HBASE-17328.branch-1.1.v4.patch, HBASE-17328.master.v4.patch > > > When adding a looped replication peer (clusterId == peerClusterId), the following code terminates the replication source thread, but since the source manager still holds a reference, WALs continue to get enqueued, and never get cleaned because they're stuck in the queue, leading to an unsustainable buildup. Furthermore, the replication statistics thread will continue to print statistics for the terminated source. > {code} > if (clusterId.equals(peerClusterId) && !replicationEndpoint.canReplicateToSameCluster()) { > this.terminate("ClusterId " + clusterId + " is replicating to itself: peerClusterId " > + peerClusterId + " which is not allowed by ReplicationEndpoint:" > + replicationEndpoint.getClass().getName(), null, false); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)