Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 14 Dec 2016 10:09:58 +0000 (UTC)
From: "Anastasia Braginsky (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13027362.1481523262000.518258.1481710198409@Atlassian.JIRA>
In-Reply-To: <JIRA.13027362.1481523262000@Atlassian.JIRA>
References: <JIRA.13027362.1481523262000@Atlassian.JIRA> <JIRA.13027362.1481523262722@arcas>
Subject: [jira] [Commented] (HBASE-17291) Remove
 ImmutableSegment#getKeyValueScanner
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 14 Dec 2016 10:10:00 -0000


    [ https://issues.apache.org/jira/browse/HBASE-17291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15747888#comment-15747888 ] 

Anastasia Braginsky commented on HBASE-17291:
---------------------------------------------

Sure!
Also then you will rebase and put on the review board?

> Remove ImmutableSegment#getKeyValueScanner
> ------------------------------------------
>
>                 Key: HBASE-17291
>                 URL: https://issues.apache.org/jira/browse/HBASE-17291
>             Project: HBase
>          Issue Type: Improvement
>          Components: Scanners
>    Affects Versions: 2.0.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17291.patch, HBASE-17291_1.patch
>
>
> This is based on a discussion over [~anastas]'s patch. The MemstoreSnapshot uses a KeyValueScanner which actually seems redundant considering we already have a SegmentScanner. The idea is that the snapshot scanner should be a simple iterator type of scanner but it lacks the capability to do the reference counting on that segment that is now used in snapshot. With snapshot having mulitple segments in the latest impl it is better we hold on to the segment by doing ref counting. 


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)