Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1F164200BDA for ; Tue, 13 Dec 2016 17:30:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 1DC2B160B35; Tue, 13 Dec 2016 16:30:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8BCAD160B07 for ; Tue, 13 Dec 2016 17:29:59 +0100 (CET) Received: (qmail 86969 invoked by uid 500); 13 Dec 2016 16:29:58 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 86940 invoked by uid 99); 13 Dec 2016 16:29:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Dec 2016 16:29:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 88CD32C03DE for ; Tue, 13 Dec 2016 16:29:58 +0000 (UTC) Date: Tue, 13 Dec 2016 16:29:58 +0000 (UTC) From: "ramkrishna.s.vasudevan (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-17291) Remove ImmutableSegment#getKeyValueScanner MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 13 Dec 2016 16:30:00 -0000 [ https://issues.apache.org/jira/browse/HBASE-17291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-17291: ------------------------------------------- Attachment: HBASE-17291.patch Patch for trunk. Removes getKVScanner() and adds a SnapshotScanner that is of type SegmentScanner. > Remove ImmutableSegment#getKeyValueScanner > ------------------------------------------ > > Key: HBASE-17291 > URL: https://issues.apache.org/jira/browse/HBASE-17291 > Project: HBase > Issue Type: Improvement > Components: Scanners > Affects Versions: 2.0.0 > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0 > > Attachments: HBASE-17291.patch > > > This is based on a discussion over [~anastas]'s patch. The MemstoreSnapshot uses a KeyValueScanner which actually seems redundant considering we already have a SegmentScanner. The idea is that the snapshot scanner should be a simple iterator type of scanner but it lacks the capability to do the reference counting on that segment that is now used in snapshot. With snapshot having mulitple segments in the latest impl it is better we hold on to the segment by doing ref counting. -- This message was sent by Atlassian JIRA (v6.3.4#6332)