Return-Path: <issues-return-272690-archive-asf-public=cust-asf.ponee.io@hbase.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 1A20B200BD9
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri,  9 Dec 2016 20:19:00 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 18D8E160B1D; Fri,  9 Dec 2016 19:19:00 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 615C4160AFD
	for <archive-asf-public@cust-asf.ponee.io>; Fri,  9 Dec 2016 20:18:59 +0100 (CET)
Received: (qmail 14703 invoked by uid 500); 9 Dec 2016 19:18:58 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 14687 invoked by uid 99); 9 Dec 2016 19:18:58 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Dec 2016 19:18:58 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 52E652C03DE
	for <issues@hbase.apache.org>; Fri,  9 Dec 2016 19:18:58 +0000 (UTC)
Date: Fri, 9 Dec 2016 19:18:58 +0000 (UTC)
From: "Thiruvel Thirumoolan (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13026863.1481254151000.485502.1481311138336@Atlassian.JIRA>
In-Reply-To: <JIRA.13026863.1481254151000@Atlassian.JIRA>
References: <JIRA.13026863.1481254151000@Atlassian.JIRA> <JIRA.13026863.1481254151582@arcas>
Subject: [jira] [Updated] (HBASE-17281) FN should use datanode port from
 hdfs configuration
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Fri, 09 Dec 2016 19:19:00 -0000


     [ https://issues.apache.org/jira/browse/HBASE-17281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thiruvel Thirumoolan updated HBASE-17281:
-----------------------------------------
    Description: 
Currently we use the ServerName port for providing favored node hints. We should use the DN port from hdfs-site.xml instead to avoid warning messages in region server logs. The warnings will be from this section of HDFS code, it moves across classes.

https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java#L1758

{code}
  private boolean[] getPinnings(DatanodeInfo[] nodes) {
    if (favoredNodes == null) {
      return null;
    } else {
      boolean[] pinnings = new boolean[nodes.length];
      HashSet<String> favoredSet = new HashSet<>(Arrays.asList(favoredNodes));
      for (int i = 0; i < nodes.length; i++) {
        pinnings[i] = favoredSet.remove(nodes[i].getXferAddrWithHostname());
        LOG.debug("{} was chosen by name node (favored={}).",
            nodes[i].getXferAddrWithHostname(), pinnings[i]);
      }
      if (!favoredSet.isEmpty()) {
        // There is one or more favored nodes that were not allocated.
        LOG.warn("These favored nodes were specified but not chosen: "
            + favoredSet + " Specified favored nodes: "
            + Arrays.toString(favoredNodes));

      }
      return pinnings;
    }
  }
{code}

  was:Currently we use the ServerName port for providing favored node hints. We should use the DN port from hdfs-site.xml instead to avoid warning messages in region server logs.


> FN should use datanode port from hdfs configuration
> ---------------------------------------------------
>
>                 Key: HBASE-17281
>                 URL: https://issues.apache.org/jira/browse/HBASE-17281
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Thiruvel Thirumoolan
>            Assignee: Thiruvel Thirumoolan
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> Currently we use the ServerName port for providing favored node hints. We should use the DN port from hdfs-site.xml instead to avoid warning messages in region server logs. The warnings will be from this section of HDFS code, it moves across classes.
> https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java#L1758
> {code}
>   private boolean[] getPinnings(DatanodeInfo[] nodes) {
>     if (favoredNodes == null) {
>       return null;
>     } else {
>       boolean[] pinnings = new boolean[nodes.length];
>       HashSet<String> favoredSet = new HashSet<>(Arrays.asList(favoredNodes));
>       for (int i = 0; i < nodes.length; i++) {
>         pinnings[i] = favoredSet.remove(nodes[i].getXferAddrWithHostname());
>         LOG.debug("{} was chosen by name node (favored={}).",
>             nodes[i].getXferAddrWithHostname(), pinnings[i]);
>       }
>       if (!favoredSet.isEmpty()) {
>         // There is one or more favored nodes that were not allocated.
>         LOG.warn("These favored nodes were specified but not chosen: "
>             + favoredSet + " Specified favored nodes: "
>             + Arrays.toString(favoredNodes));
>       }
>       return pinnings;
>     }
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)