Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8154B200BE4 for ; Wed, 7 Dec 2016 03:00:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 7FF54160B2A; Wed, 7 Dec 2016 02:00:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D3518160B1B for ; Wed, 7 Dec 2016 02:59:59 +0100 (CET) Received: (qmail 28648 invoked by uid 500); 7 Dec 2016 01:59:59 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 28635 invoked by uid 99); 7 Dec 2016 01:59:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Dec 2016 01:59:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D1F592C03E1 for ; Wed, 7 Dec 2016 01:59:58 +0000 (UTC) Date: Wed, 7 Dec 2016 01:59:58 +0000 (UTC) From: "huaxiang sun (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-17249) Get/Scan's setTimeRange/setColumnFamilyTimeRange can take the TimeRange reference as the parameter instead of creating a new setColumnFamilyTimeRange instance MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 07 Dec 2016 02:00:00 -0000 [ https://issues.apache.org/jira/browse/HBASE-17249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] huaxiang sun updated HBASE-17249: --------------------------------- Attachment: HBASE-17249-master-003.patch v3 patch to address Anoop's comments. > Get/Scan's setTimeRange/setColumnFamilyTimeRange can take the TimeRange reference as the parameter instead of creating a new setColumnFamilyTimeRange instance > -------------------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: HBASE-17249 > URL: https://issues.apache.org/jira/browse/HBASE-17249 > Project: HBase > Issue Type: Improvement > Affects Versions: 2.0.0 > Reporter: huaxiang sun > Assignee: huaxiang sun > Priority: Minor > Attachments: HBASE-17249-master-001.patch, HBASE-17249-master-002.patch, HBASE-17249-master-003.patch > > > Going through the code, found For Get/Scan's setTimeRange/setColumnFamilyTimeRange, it can use TimeRange as reference instead of creating a new one. > Reference: > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L500 > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L506 > We can implement this in a similar way as filter: > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L510 > I checked it is same with branch-1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)